<div class="gmail_quote">On Wed, Jun 16, 2010 at 4:54 PM, Kris Jurka <span dir="ltr"><<a href="mailto:books@ejurka.com">books@ejurka.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">
<div class="im">On 6/16/2010 1:35 PM, Muhammad Mansoor wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Hi,<br>
<br>
The attached patch takes care of the following issues.<br>
<br>
1. It adds PostgreSQL 9.0 support.<br>
</blockquote>
<br></div>
The code in CVS already supports postgresql 9.0. You need to create your patch from CVS, not from the 1.4.0 source release.<br></blockquote><div><br></div><div>Sure I will do that. </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">
<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="im">
2. It has the JDK support patch ( taken from /Petr Michálek original<br></div>
patch/ )<br>
</blockquote>
<br>
Your patch has all the problems his does, tons of gratuitous whitespace changes. You should not be reformatting/re-indenting unrelated code.<div class="im"><br>
<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
3. It enables PLjava to be compiled with both JDK 5 and JDK 6.<br>
</blockquote>
<br></div>
It does not appear to do this. A quick search through the patch doesn't reveal any matches for JDBC4 or USE_JDK6.<br></blockquote><div><br></div><div>These changes are there in the start of patch.</div><div><br></div>
<div>+ output := $(shell rm -rf "src/java/pljava/org/postgresql/pljava/jdbc")</div><div>+ </div><div>+ ifdef USE_JDK6</div><div>+ output := $(shell cp -rf "src/java/pljava/org/postgresql/pljava/jdbc4" "src/java/pljava/org/postgresql/pljava/jdbc")</div>
<div>+ else</div><div>+ output := $(shell cp -rf "src/java/pljava/org/postgresql/pljava/jdbc3" "src/java/pljava/org/postgresql/pljava/jdbc")</div><div>+ endif</div><div>+ </div><div> </div><div>
<br></div><div>I will make it more cleaner. Do you agree with the solution?</div><div><br></div><div>Thanks,</div><div><br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">
<font color="#888888">
<br>
Kris Jurka<br>
</font></blockquote></div><br><br clear="all"><br>-- <br>Syed Muhammad Mansoor<br>Architect<br>EnterpriseDB Corporation<br>The Enterprise Postgres Company<br><br>